Skip to content

Add namespace support for rviz costmap cost tool (backport #5268)#5269

Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-5268
Closed

Add namespace support for rviz costmap cost tool (backport #5268)#5269
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-5268

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jun 13, 2025

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on My robot
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

When adding the costmap cost tool in rviz, I noticed it does not return the value of global/local costmap tool when clicking, it is mainly because I have a namespace for my node, so I removed the "/" part

Description of documentation updates required from your changes

Description of how this change was tested

Tested on my robot

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
This is an automatic backport of pull request #5268 done by [Mergify](https://mergify.com).

@mini-1235 @mergify
Add namespace support for rviz costmap cost tool (#5268)
9f56313 
Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 33e78d7)

# Conflicts:
#	nav2_rviz_plugins/src/costmap_cost_tool.cpp
@mergify mergify Bot added the conflicts label Jun 13, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Jun 13, 2025

Cherry-pick of 33e78d7 has failed:

On branch mergify/bp/jazzy/pr-5268
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 33e78d74.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   nav2_rviz_plugins/src/costmap_cost_tool.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Jun 13, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Jun 13, 2025

@mini-1235 this didnt auto-backport. Can you open a Jazzy PR? I’m on the go today and can’t do those changes (even as trivially easy they are) on my phone.

@mini-1235
Copy link
Copy Markdown
Collaborator

mini-1235 commented Jun 13, 2025

@mini-1235 this didnt auto-backport. Can you open a Jazzy PR? I’m on the go today and can’t do those changes (even as trivially easy they are) on my phone.

Sure

@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-5268 branch June 13, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SteveMacenski @mini-1235